Do we intend this PR to supersede #144 @colemancda @lhoward ?

I haven’t been following this one. Is it a superset of mine? If so, makes sense. If it’s an intersecting set then, I would propose reviewing mine and then rebasing this one after it is merged (presuming it is approved).

I'd like for us to catch up, it's a bit tricky for me to accept PRs without Android CI and without clear picture which ones we should be moving forward with and what is only PoC etc. Both are Draft so I understand them not really intended as being merged, but I also don't want to waste either of your efforts.

Will both of you in the android/java call we're scheduling with the android workgroup?

I’ll be. Sorry I only get to check in on this every month or so after an initial spurt of activity!

No problem at all :-) Just trying to figure out what everyone's plans here are 👍

It does that appear @colemancda has duplicated much of the work in the original PR, which I suppose is my fault for not following up on trying to get it merged earlier.

Comments on specific commits are below (I've avoided using commit hashes are they're liable to change).

• [JavaRuntime] Add Android shims: dlopen()'ing libnativehelper.so was in my original patch set, but was removed IIRC at @ktoso's suggestion. NDK versions 31 and above export the necessary symbols. I don't have a particularly strong position on this (if it works, it works), but arguably we shouldn't be using symbols that we can't link at build time.
• JavaKit: always use ambient javaEnvironment on Android: I approve this fix, as it's cherry-picked from my PR.
• [JavaKit] Add JNIEnvPointer for Android: this was included in my commit JavaKit: support for Android NDK JVM; no objection to it being a distinct commit, but suggest a more verbose commit message.
• [JavaKit] Fix JNINativeInterface_ for Android: as above.
• [JavaKit] Don't include JVM path for Android: as above.

The commit:

• Samples: add sample Android app

from my PR may be useful to include.